From 4437cdabf01c8d661c580fa9cea65eced78dd480 Mon Sep 17 00:00:00 2001 From: Pierre-Eric Pelloux-Prayer Date: Wed, 16 Apr 2025 11:27:54 +0200 Subject: [PATCH] winsys/amdgpu: disable VM_ALWAYS_VALID MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The referenced commit has been identified as the root cause of graphic artifacts / hangs on some APUs. For now disable AMDGPU_GEM_CREATE_VM_ALWAYS_VALID on all chips except when user queues are used. See https://gitlab.freedesktop.org/mesa/mesa/-/issues/12809. Fixes: 8c91624614c ("winsys/amdgpu: use VM_ALWAYS_VALID for all VRAM and GTT allocations") Reviewed-by: Marek Olšák Part-of: (cherry picked from commit 555821ff93118d4a6ea441127cd0427a95743d47) --- .pick_status.json | 2 +- src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index 9404283e56c..99df2fb30c2 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -4,7 +4,7 @@ "description": "winsys/amdgpu: disable VM_ALWAYS_VALID", "nominated": true, "nomination_type": 2, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "8c91624614c1f939974fe0d2d1a3baf83335cecb", "notes": null diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c b/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c index 1a4cfea8914..e107220bed7 100644 --- a/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c +++ b/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c @@ -62,7 +62,7 @@ static bool do_winsys_init(struct amdgpu_winsys *aws, simple_mtx_init(&aws->queues[i].userq.lock, mtx_plain); /* TODO: Enable this once the kernel handles it efficiently. */ - if (aws->info.has_dedicated_vram && !aws->info.use_userq) + if (!aws->info.use_userq) aws->info.has_local_buffers = false; return true;