From 43b9a2ea5e90995f72b41ae8e43bd8a6e547dfa3 Mon Sep 17 00:00:00 2001 From: Lars-Ivar Hesselberg Simonsen Date: Mon, 26 Jan 2026 11:29:43 +0100 Subject: [PATCH] panvk: Fix dcd_flags1 dirty bit dcd_flags1 was not counted as dirty in case the color attachment map was updated. This could lead to an outdated value for render_target_mask. Fixes: a4670a67e0e ("panvk/csf: Set the correct DCD_FLAGS_1.render_rarget_mask") Reviewed-by: Christoph Pillmayer Acked-by: Erik Faye-Lund (cherry picked from commit 75242b18623aa7316520e6e81fdb8b9c7a3ec43b) Part-of: --- .pick_status.json | 2 +- src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.pick_status.json b/.pick_status.json index f68ab05d4b7..d6253661859 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -4114,7 +4114,7 @@ "description": "panvk: Fix dcd_flags1 dirty bit", "nominated": true, "nomination_type": 2, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "a4670a67e0ea5fa4ed3885d0d3bd7b008f14abf1", "notes": null diff --git a/src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c b/src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c index 00d7bd9f713..4bffba41e25 100644 --- a/src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c +++ b/src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c @@ -1995,6 +1995,7 @@ prepare_dcd(struct panvk_cmd_buffer *cmdbuf, /* line mode needs primitive topology */ dyn_gfx_state_dirty(cmdbuf, RS_LINE_MODE) || dyn_gfx_state_dirty(cmdbuf, IA_PRIMITIVE_TOPOLOGY) || + dyn_gfx_state_dirty(cmdbuf, COLOR_ATTACHMENT_MAP) || fs_user_dirty(cmdbuf) || gfx_state_dirty(cmdbuf, RENDER_STATE);