fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-07 09:18:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

panvk: Fix dcd_flags1 dirty bit

Browse source 
dcd_flags1 was not counted as dirty in case the color attachment map was
updated. This could lead to an outdated value for render_target_mask.

Fixes: a4670a67e0 ("panvk/csf: Set the correct DCD_FLAGS_1.render_rarget_mask")
Reviewed-by: Christoph Pillmayer <christoph.pillmayer@arm.com>
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
(cherry picked from commit 75242b1862)

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/40092>
This commit is contained in:
Lars-Ivar Hesselberg Simonsen 2026-01-26 11:29:43 +01:00 • committed by Eric Engestrom
parent 98e2234eb4
commit 43b9a2ea5e
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -4114,7 +4114,7 @@
"description": "panvk: Fix dcd_flags1 dirty bit",
"nominated": true,
"nomination_type": 2,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "a4670a67e0ea5fa4ed3885d0d3bd7b008f14abf1",
"notes": null

1
src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c
View file

@ -1995,6 +1995,7 @@ prepare_dcd(struct panvk_cmd_buffer *cmdbuf,
/* line mode needs primitive topology */
dyn_gfx_state_dirty(cmdbuf, RS_LINE_MODE) ||
dyn_gfx_state_dirty(cmdbuf, IA_PRIMITIVE_TOPOLOGY) ||
dyn_gfx_state_dirty(cmdbuf, COLOR_ATTACHMENT_MAP) ||
fs_user_dirty(cmdbuf) ||
gfx_state_dirty(cmdbuf, RENDER_STATE);