From 43a6a2151b07d1fc6975026746f11779c58fc818 Mon Sep 17 00:00:00 2001 From: Caio Marcelo de Oliveira Filho Date: Thu, 27 May 2021 14:39:03 -0700 Subject: [PATCH] compiler: Rename SYSTEM_VALUE_LOCAL_GROUP_SIZE to SYSTEM_VALUE_WORKGROUP_SIZE MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Acked-by: Emma Anholt Acked-by: Alyssa Rosenzweig Reviewed-by: Jason Ekstrand Acked-by: Timur Kristóf Part-of: --- src/compiler/glsl/builtin_variables.cpp | 2 +- src/compiler/glsl/lower_cs_derived.cpp | 2 +- src/compiler/nir/nir.c | 4 ++-- src/compiler/shader_enums.c | 2 +- src/compiler/shader_enums.h | 2 +- src/compiler/spirv/vtn_variables.c | 2 +- src/gallium/auxiliary/tgsi/tgsi_from_mesa.c | 2 +- src/gallium/drivers/radeonsi/si_shader_nir.c | 2 +- 8 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/compiler/glsl/builtin_variables.cpp b/src/compiler/glsl/builtin_variables.cpp index 8be36eda5bd..a314e32d029 100644 --- a/src/compiler/glsl/builtin_variables.cpp +++ b/src/compiler/glsl/builtin_variables.cpp @@ -1456,7 +1456,7 @@ builtin_variable_generator::generate_cs_special_vars() add_system_value(SYSTEM_VALUE_NUM_WORK_GROUPS, uvec3_t, "gl_NumWorkGroups"); if (state->ARB_compute_variable_group_size_enable) { - add_system_value(SYSTEM_VALUE_LOCAL_GROUP_SIZE, + add_system_value(SYSTEM_VALUE_WORKGROUP_SIZE, uvec3_t, "gl_LocalGroupSizeARB"); } diff --git a/src/compiler/glsl/lower_cs_derived.cpp b/src/compiler/glsl/lower_cs_derived.cpp index 69ee3990bb7..85a57232b61 100644 --- a/src/compiler/glsl/lower_cs_derived.cpp +++ b/src/compiler/glsl/lower_cs_derived.cpp @@ -138,7 +138,7 @@ lower_cs_derived_visitor::find_sysvals() if (local_size_variable) { gl_WorkGroupSize = new(shader) ir_dereference_variable( add_system_value( - SYSTEM_VALUE_LOCAL_GROUP_SIZE, glsl_type::uvec3_type, + SYSTEM_VALUE_WORKGROUP_SIZE, glsl_type::uvec3_type, "gl_LocalGroupSizeARB")); } else { ir_constant_data data; diff --git a/src/compiler/nir/nir.c b/src/compiler/nir/nir.c index 1a3fd5c6f9c..9aa91cdcbff 100644 --- a/src/compiler/nir/nir.c +++ b/src/compiler/nir/nir.c @@ -2019,7 +2019,7 @@ nir_intrinsic_from_system_value(gl_system_value val) return nir_intrinsic_load_num_subgroups; case SYSTEM_VALUE_SUBGROUP_ID: return nir_intrinsic_load_subgroup_id; - case SYSTEM_VALUE_LOCAL_GROUP_SIZE: + case SYSTEM_VALUE_WORKGROUP_SIZE: return nir_intrinsic_load_local_group_size; case SYSTEM_VALUE_GLOBAL_INVOCATION_ID: return nir_intrinsic_load_global_invocation_id; @@ -2151,7 +2151,7 @@ nir_system_value_from_intrinsic(nir_intrinsic_op intrin) case nir_intrinsic_load_subgroup_id: return SYSTEM_VALUE_SUBGROUP_ID; case nir_intrinsic_load_local_group_size: - return SYSTEM_VALUE_LOCAL_GROUP_SIZE; + return SYSTEM_VALUE_WORKGROUP_SIZE; case nir_intrinsic_load_global_invocation_id: return SYSTEM_VALUE_GLOBAL_INVOCATION_ID; case nir_intrinsic_load_base_global_invocation_id: diff --git a/src/compiler/shader_enums.c b/src/compiler/shader_enums.c index 7c53a09ce9b..b1eae07c86e 100644 --- a/src/compiler/shader_enums.c +++ b/src/compiler/shader_enums.c @@ -277,7 +277,7 @@ gl_system_value_name(gl_system_value sysval) ENUM(SYSTEM_VALUE_GLOBAL_INVOCATION_INDEX), ENUM(SYSTEM_VALUE_WORK_GROUP_ID), ENUM(SYSTEM_VALUE_NUM_WORK_GROUPS), - ENUM(SYSTEM_VALUE_LOCAL_GROUP_SIZE), + ENUM(SYSTEM_VALUE_WORKGROUP_SIZE), ENUM(SYSTEM_VALUE_GLOBAL_GROUP_SIZE), ENUM(SYSTEM_VALUE_USER_DATA_AMD), ENUM(SYSTEM_VALUE_WORK_DIM), diff --git a/src/compiler/shader_enums.h b/src/compiler/shader_enums.h index 7522bdbd77c..541742517e1 100644 --- a/src/compiler/shader_enums.h +++ b/src/compiler/shader_enums.h @@ -712,7 +712,7 @@ typedef enum SYSTEM_VALUE_GLOBAL_INVOCATION_INDEX, SYSTEM_VALUE_WORK_GROUP_ID, SYSTEM_VALUE_NUM_WORK_GROUPS, - SYSTEM_VALUE_LOCAL_GROUP_SIZE, + SYSTEM_VALUE_WORKGROUP_SIZE, SYSTEM_VALUE_GLOBAL_GROUP_SIZE, SYSTEM_VALUE_WORK_DIM, SYSTEM_VALUE_USER_DATA_AMD, diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c index e832a472879..c3b5fc7e4ff 100644 --- a/src/compiler/spirv/vtn_variables.c +++ b/src/compiler/spirv/vtn_variables.c @@ -919,7 +919,7 @@ vtn_get_builtin_location(struct vtn_builder *b, break; case SpvBuiltInWorkgroupSize: case SpvBuiltInEnqueuedWorkgroupSize: - *location = SYSTEM_VALUE_LOCAL_GROUP_SIZE; + *location = SYSTEM_VALUE_WORKGROUP_SIZE; set_mode_system_value(b, mode); break; case SpvBuiltInWorkgroupId: diff --git a/src/gallium/auxiliary/tgsi/tgsi_from_mesa.c b/src/gallium/auxiliary/tgsi/tgsi_from_mesa.c index 4b488276520..88ee6bb6543 100644 --- a/src/gallium/auxiliary/tgsi/tgsi_from_mesa.c +++ b/src/gallium/auxiliary/tgsi/tgsi_from_mesa.c @@ -269,7 +269,7 @@ tgsi_get_sysval_semantic(unsigned sysval) return TGSI_SEMANTIC_BLOCK_ID; case SYSTEM_VALUE_NUM_WORK_GROUPS: return TGSI_SEMANTIC_GRID_SIZE; - case SYSTEM_VALUE_LOCAL_GROUP_SIZE: + case SYSTEM_VALUE_WORKGROUP_SIZE: return TGSI_SEMANTIC_BLOCK_SIZE; /* ARB_shader_ballot */ diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 6f97254773a..aeeb0988e87 100644 --- a/src/gallium/drivers/radeonsi/si_shader_nir.c +++ b/src/gallium/drivers/radeonsi/si_shader_nir.c @@ -435,7 +435,7 @@ void si_nir_scan_shader(const struct nir_shader *nir, struct si_shader_info *inf info->uses_subgroup_info = BITSET_TEST(nir->info.system_values_read, SYSTEM_VALUE_LOCAL_INVOCATION_INDEX) || BITSET_TEST(nir->info.system_values_read, SYSTEM_VALUE_SUBGROUP_ID) || BITSET_TEST(nir->info.system_values_read, SYSTEM_VALUE_NUM_SUBGROUPS); - info->uses_variable_block_size = BITSET_TEST(nir->info.system_values_read, SYSTEM_VALUE_LOCAL_GROUP_SIZE); + info->uses_variable_block_size = BITSET_TEST(nir->info.system_values_read, SYSTEM_VALUE_WORKGROUP_SIZE); info->uses_drawid = BITSET_TEST(nir->info.system_values_read, SYSTEM_VALUE_DRAW_ID); info->uses_primid = BITSET_TEST(nir->info.system_values_read, SYSTEM_VALUE_PRIMITIVE_ID) || nir->info.inputs_read & VARYING_BIT_PRIMITIVE_ID;