From 43258dc802e07894ae3edd9ea98337a9dc7a0e8e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= Date: Sun, 28 Nov 2021 17:57:25 +0100 Subject: [PATCH] egl/wayland: fix crash in dri2_initialize_wayland_drm MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When "dri2_wl_formats_init" fails in "dri2_initialize_wayland_drm", the "dri2_display_destroy" function is called for clean up. However, the "dri2_egl_display" was not associated with the display in its "DriverData" field yet. The following cast in "dri2_display_destroy": struct dri2_egl_display *dri2_dpy = dri2_egl_display(disp); Expands to: _EGL_DRIVER_TYPECAST(drvname ## _display, _EGLDisplay, obj->DriverData) Crashing. Addresses-Coverity-ID: 1494541 ("Resource leak") Signed-off-by: José Expósito Part-of: --- src/egl/drivers/dri2/platform_wayland.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index 1c2d9540da9..242cf5891d9 100644 --- a/src/egl/drivers/dri2/platform_wayland.c +++ b/src/egl/drivers/dri2/platform_wayland.c @@ -2045,11 +2045,12 @@ dri2_initialize_wayland_drm(_EGLDisplay *disp) if (!dri2_dpy) return _eglError(EGL_BAD_ALLOC, "eglInitialize"); + dri2_dpy->fd = -1; + disp->DriverData = (void *) dri2_dpy; + if (dri2_wl_formats_init(&dri2_dpy->formats) < 0) goto cleanup; - dri2_dpy->fd = -1; - disp->DriverData = (void *) dri2_dpy; if (disp->PlatformDisplay == NULL) { dri2_dpy->wl_dpy = wl_display_connect(NULL); if (dri2_dpy->wl_dpy == NULL)