fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 15:38:09 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

i965: Don't make instructions with a null dest a barrier to scheduling.

Browse source 
Now that we properly track accumulator dependencies, the scheduler is
able to schedule instructions between the mach and mov in the common
the integer multiplication pattern:

   mul  acc0, x, y
   mach null, x, y
   mov  dest, acc0

Since a null destination implies no dependency on the destination, we
can also safely schedule instructions (that don't write the accumulator)
between the mul and mach.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
This commit is contained in:
Matt Turner 2014-04-09 13:38:14 -07:00
parent a6860100b8
commit 42a26cb5e4
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp
View file

@ -870,7 +870,8 @@ fs_instruction_scheduler::calculate_deps()
} else if (inst->dst.is_accumulator() && gen6plus) { } else if (inst->dst.is_accumulator() && gen6plus) {
add_dep(last_accumulator_write, n); add_dep(last_accumulator_write, n);
last_accumulator_write = n; last_accumulator_write = n;
} else if (inst->dst.file != BAD_FILE) { } else if (inst->dst.file != BAD_FILE &&
!inst->dst.is_null()) {
add_barrier_deps(n); add_barrier_deps(n);
} }
@ -997,7 +998,8 @@ fs_instruction_scheduler::calculate_deps()
} }
} else if (inst->dst.is_accumulator() && gen6plus) { } else if (inst->dst.is_accumulator() && gen6plus) {
last_accumulator_write = n; last_accumulator_write = n;
} else if (inst->dst.file != BAD_FILE) { } else if (inst->dst.file != BAD_FILE &&
!inst->dst.is_null()) {
add_barrier_deps(n); add_barrier_deps(n);
} }
@ -1113,7 +1115,8 @@ vec4_instruction_scheduler::calculate_deps()
} else if (inst->dst.is_accumulator() && gen6plus) { } else if (inst->dst.is_accumulator() && gen6plus) {
add_dep(last_accumulator_write, n); add_dep(last_accumulator_write, n);
last_accumulator_write = n; last_accumulator_write = n;
} else if (inst->dst.file != BAD_FILE) { } else if (inst->dst.file != BAD_FILE &&
!inst->dst.is_null()) {
add_barrier_deps(n); add_barrier_deps(n);
} }
@ -1205,7 +1208,8 @@ vec4_instruction_scheduler::calculate_deps()
last_fixed_grf_write = n; last_fixed_grf_write = n;
} else if (inst->dst.is_accumulator() && gen6plus) { } else if (inst->dst.is_accumulator() && gen6plus) {
last_accumulator_write = n; last_accumulator_write = n;
} else if (inst->dst.file != BAD_FILE) { } else if (inst->dst.file != BAD_FILE &&
!inst->dst.is_null()) {
add_barrier_deps(n); add_barrier_deps(n);
} }