fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-07 13:38:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

aco/optimizer: don't propagate subdword temps of different size

Browse source 
It could happen that due to inconsistent copy-propagation

  v1 = p_parallelcopy v2b

instructions were left after optimization on GFX8.

Cc: 20.3
Cc: 21.0

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8260>
(cherry picked from commit 856fd4750d)
This commit is contained in:
Daniel Schürmann 2020-12-28 19:15:17 +00:00 • committed by Dylan Baker
parent 773a46157e
commit 4257b87367
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -2497,7 +2497,7 @@
"description": "aco/optimizer: don't propagate subdword temps of different size",
"nominated": false,
"nomination_type": null,
"resolution": 4,
"resolution": 1,
"master_sha": null,
"because_sha": null
},

3
src/amd/compiler/aco_optimizer.cpp
View file

@ -858,7 +858,8 @@ void label_instruction(opt_ctx &ctx, Block& block, aco_ptr<Instruction>& instr)
if (info.is_temp() && info.temp.type() == RegType::sgpr) {
instr->operands[i].setTemp(info.temp);
info = ctx.info[info.temp.id()];
} else if (info.is_temp() && info.temp.type() == RegType::vgpr) {
} else if (info.is_temp() && info.temp.type() == RegType::vgpr &&
info.temp.bytes() == instr->operands[i].bytes()) {
/* propagate vgpr if it can take it */
switch (instr->opcode) {
case aco_opcode::p_create_vector: