fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 02:38:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

agx: Validate immediates

Browse source 
In particular the new sizing rules.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18687>
This commit is contained in:
Alyssa Rosenzweig 2022-09-10 15:58:25 -04:00 • committed by Marge Bot
parent 14f2be1f33
commit 3e86522cf2
1 changed files with 33 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
src/asahi/compiler/agx_validate.c
View file

@ -88,6 +88,31 @@ agx_validate_block_form(agx_block *block)
return true;
}
static bool
agx_validate_sources(agx_instr *I)
{
agx_foreach_src(I, s) {
agx_index src = I->src[s];
if (src.type == AGX_INDEX_IMMEDIATE) {
agx_validate_assert(!src.kill);
agx_validate_assert(!src.cache);
agx_validate_assert(!src.discard);
/* Immediates are encoded as 8-bit. For integers, they extend to
* 16-bit. For floating point, they are 8-bit minifloats. The 8-bit
* minifloats are a strict subset of 16-bit standard floats, so we
* treat them as such in the IR, with an implicit f16->f32 for 32-bit
* floating point operations.
*/
agx_validate_assert(src.size == AGX_SIZE_16);
agx_validate_assert(src.value < 0x100);
}
}
return true;
}
void
agx_validate(agx_context *ctx, const char *after)
{
@ -104,6 +129,14 @@ agx_validate(agx_context *ctx, const char *after)
}
}
agx_foreach_instr_global(ctx, I) {
if (!agx_validate_sources(I)) {
fprintf(stderr, "Invalid sources form after %s\n", after);
agx_print_instr(I, stdout);
fail = true;
}
}
/* TODO: Validate more invariants */
if (fail) {