fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-09 02:28:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

nir/lower_is_helper_invocation: create load_helper_invocation instr with bitsize=1

Browse source 
the specification stipulates that this is a bool value, so don't load it as an int
or else nir_validate explodes

Fixes: f17b41ab4f ("nir: add lowering pass for helperInvocationEXT()")

Reviewed-by: Danylo Piliaiev <dpiliaiev@igalia.com>

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15402>
(cherry picked from commit cdcfcb7916)
This commit is contained in:
Mike Blumenkrantz 2022-03-14 15:45:17 -04:00 • committed by Dylan Baker
parent 847a5dceea
commit 3e37848f50
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -748,7 +748,7 @@
"description": "nir/lower_is_helper_invocation: create load_helper_invocation instr with bitsize=1",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"because_sha": "f17b41ab4f017b562fdf7c388200e68c22105331"
},
{

2
src/compiler/nir/nir_lower_is_helper_invocation.c
View file

@ -114,7 +114,7 @@ nir_lower_is_helper_invocation(nir_shader *shader)
glsl_bool_type(),
"gl_IsHelperInvocationEXT");
nir_ssa_def *started_as_helper = nir_load_helper_invocation(&b, 32);
nir_ssa_def *started_as_helper = nir_load_helper_invocation(&b, 1);
nir_deref_instr *is_helper_deref = nir_build_deref_var(&b, is_helper);
nir_store_deref(&b, is_helper_deref, started_as_helper, 1);