fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-24 01:58:16 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

spirv: Stop warning about ignored invalid ArrayStride decorations

Browse source 
In practice, these warnings produce more noise than signal.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41758>
This commit is contained in:
Caio Oliveira 2026-05-21 21:29:20 -07:00 • committed by Marge Bot
parent d74a03a70d
commit 3ded84870f
1 changed files with 12 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/compiler/spirv/spirv_to_nir.c
View file

@ -1509,14 +1509,19 @@ array_stride_decoration_cb(struct vtn_builder *b,
if (type->base_type == vtn_base_type_pointer &&
type->pointed != NULL &&
(type->pointed->block || type->pointed->buffer_block)) {
vtn_warn("A pointer to a structure decorated with *Block* or "
"*BufferBlock* must not have an *ArrayStride* decoration");
/* Ignore the decoration */
/* Ignore invalid decoration:
*
* A pointer to a structure decorated with *Block* or
* *BufferBlock* must not have an *ArrayStride* decoration
*/
} else if (vtn_type_contains_block(b, type)) {
vtn_warn("The ArrayStride decoration cannot be applied to an array "
"type which contains a structure type decorated Block "
"or BufferBlock");
/* Ignore the decoration */
/* Ignore invalid decoration:
*
* Each array type must have an ArrayStride decoration,
* unless it is an array that contains a structure decorated
* with Block or BufferBlock, in which case it must not have
* an ArrayStride decoration.
*/
} else {
vtn_fail_if(dec->operands[0] == 0, "ArrayStride must be non-zero");
type->stride = dec->operands[0];