fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-02-24 22:30:31 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

venus: virtgpu: Require stable wire format
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
Details
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Details

Browse source 
When VMMs do not support VIRTGPU_DRM_CAPSET_VENUS the capset data
remains zeroed. By requiring the stable wire_format_version 1 this can
be detected early without initialising the renderer.

Avoids triggering `assert(capset->supports_blob_id_0);` in debug builds
under such circumstances.

Cc: mesa-stable
Signed-off-by: Janne Grunau <j@jannau.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34613>
This commit is contained in:
Janne Grunau 2025-04-18 18:52:25 +02:00 • committed by Marge Bot
parent 2a4675ee9f
commit 3d3ca9b65e
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/virtio/vulkan/vn_renderer_virtgpu.c
View file

@ -1490,6 +1490,14 @@ virtgpu_init_capset(struct virtgpu *gpu)
return VK_ERROR_INITIALIZATION_FAILED;
}
if (gpu->capset.data.wire_format_version == 0) {
if (VN_DEBUG(INIT)) {
vn_log(gpu->instance, "Unsupported wire format version %u",
gpu->capset.data.wire_format_version);
}
return VK_ERROR_INITIALIZATION_FAILED;
}
return VK_SUCCESS;
}