From 3ce19d2db2bea24d4d3944a640459c0f7bfb5d02 Mon Sep 17 00:00:00 2001 From: Emma Anholt Date: Tue, 16 Nov 2021 16:17:25 -0800 Subject: [PATCH] llvmpipe: Disable an assertion that may not be quite right. It triggered on uprevving VK-GL-CTS, and @airlied says it's tripped apparently spuriously before. There seems to be some interesting logic behind it, so leave the big comment for whoever can revisit the issue some day. Acked-by: Dave Airlie Part-of: --- src/gallium/drivers/llvmpipe/lp_rast_tri_tmp.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/llvmpipe/lp_rast_tri_tmp.h b/src/gallium/drivers/llvmpipe/lp_rast_tri_tmp.h index bced19c2252..b05f58cb3a9 100644 --- a/src/gallium/drivers/llvmpipe/lp_rast_tri_tmp.h +++ b/src/gallium/drivers/llvmpipe/lp_rast_tri_tmp.h @@ -254,8 +254,10 @@ TAG(lp_rast_triangle)(struct lp_rasterizer_task *task, * (in which case the tri will not get binned), or trivial accept for * the whole tile (in which case plane_mask will not include it). */ +#if 0 assert((c[j] >> (int64_t)FIXED_ORDER) > (int32_t)0xb0000000 && (c[j] >> (int64_t)FIXED_ORDER) < (int32_t)0x3fffffff); +#endif /* * Note the fixup part is constant throughout the tile - thus could * just calculate this and avoid _all_ 64bit math in rasterization