fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-06-14 22:18:20 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

v3d: simplify fast TLB blit format check

Browse source 
The previous commit added a v3d_get_rt_format() check to reject
fast TLB blits when the job's RT format differs from the blit
destination. Since each RT format maps to a unique (internal_type,
bpp) pair via get_internal_type_bpp_for_output_format(), the
rt_format equality check is strictly stronger than the previous
internal_type/bpp comparison.

Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/40200>
This commit is contained in:
Jose Maria Casanova Crespo 2026-03-03 11:28:38 +01:00 • committed by Marge Bot
parent 5454221cfb
commit 3cd8ea5356
1 changed files with 4 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
src/gallium/drivers/v3d/v3d_blit.c
View file

@ -452,29 +452,13 @@ v3d_tlb_blit_fast(struct pipe_context *pctx, struct pipe_blit_info *info)
info->dst.format, info->dst.level,
info->dst.box.z);
/* The job's RT setup must be compatible with the blit buffer. */
struct pipe_surface *spsurf = &job->cbufs[idx];
uint8_t sinternal_bpp, rinternal_bpp;
uint8_t sinternal_type, rinternal_type;
v3d_format_get_internal_type_and_bpp(devinfo,
spsurf->format,
&sinternal_type,
&sinternal_bpp);
v3d_format_get_internal_type_and_bpp(devinfo,
dbuf.format,
&rinternal_type,
&rinternal_bpp);
if (sinternal_bpp < rinternal_bpp ||
sinternal_type != rinternal_type) {
pipe_resource_reference(&dbuf.texture, NULL);
return;
}
/* If the blit destination uses a different RT format the channel
* layout won't match and we would corrupt the data (e.g. storing
* 10-10-10-2 channels as 16-16).
* 10-10-10-2 channels as 16-16). Since each RT format maps to a
* unique (internal_type, bpp) pair, this guarantees type and bpp
* compatibility.
*/
struct pipe_surface *spsurf = &job->cbufs[idx];
if (v3d_get_rt_format(devinfo, spsurf->format) !=
v3d_get_rt_format(devinfo, dbuf.format)) {
pipe_resource_reference(&dbuf.texture, NULL);