fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-09 15:28:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

anv: check for pending_db_mode when dirtying descriptor mode

Browse source 
If an application switches back and forth between descriptor sets and
descriptor buffers before executing a draw/dispatch, we could end up in
a wrong state due to pending_db_mode not getting updated.

Fixes: ab7641b8dc ("anv: implement descriptor buffer binding")
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36768>
(cherry picked from commit 382b8e3aa2)
This commit is contained in:
Iván Briano 2025-08-13 16:36:11 -07:00 • committed by Eric Engestrom
parent 723ce7ce8f
commit 3cd6ddf46c
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -2824,7 +2824,7 @@
"description": "anv: check for pending_db_mode when dirtying descriptor mode",
"nominated": true,
"nomination_type": 2,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "ab7641b8dcbfee419b761abb27fe6fed476b4e05",
"notes": null

2
src/intel/vulkan/anv_cmd_buffer.c
View file

@ -762,7 +762,7 @@ static void
anv_cmd_buffer_maybe_dirty_descriptor_mode(struct anv_cmd_buffer *cmd_buffer,
enum anv_cmd_descriptor_buffer_mode new_mode)
{
if (cmd_buffer->state.current_db_mode == new_mode)
if (cmd_buffer->state.pending_db_mode == new_mode)
return;
/* Ensure we program the STATE_BASE_ADDRESS properly at least once */