From 3a10d1be0e9840d16ffa1c8024b193c5aa2e0995 Mon Sep 17 00:00:00 2001 From: Lucas Stach Date: Tue, 26 Mar 2024 18:11:56 +0100 Subject: [PATCH] etnaviv: fix depth writes without testing Depth writes are only gated by the depth writemask. The state object member depth_enabled must only affect depth testing. Fixes: b29fe26d4387 ("etnaviv: rework ZSA into a derived state") Signed-off-by: Lucas Stach Reviewed-by: Christian Gmeiner Part-of: --- src/gallium/drivers/etnaviv/etnaviv_zsa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_zsa.c b/src/gallium/drivers/etnaviv/etnaviv_zsa.c index 38971e72916..7bdbf53f694 100644 --- a/src/gallium/drivers/etnaviv/etnaviv_zsa.c +++ b/src/gallium/drivers/etnaviv/etnaviv_zsa.c @@ -48,7 +48,7 @@ etna_zsa_state_create(struct pipe_context *pctx, cs->base = *so; cs->z_test_enabled = so->depth_enabled && so->depth_func != PIPE_FUNC_ALWAYS; - cs->z_write_enabled = so->depth_enabled && so->depth_writemask; + cs->z_write_enabled = so->depth_writemask; /* XXX does stencil[0] / stencil[1] order depend on rs->front_ccw? */