fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-03 22:20:09 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

main: fix coverity error in _mesa_program_resource_find_name()

Browse source 
We did not take into account if name is NULL, so we could dereference
a NULL pointer in strncmp() call.

Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
This commit is contained in:
Samuel Iglesias Gonsálvez 2020-01-08 19:12:53 +01:00
parent f2f1277624
commit 39c1892dd8
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/mesa/main/shader_query.cpp
View file

@ -581,8 +581,11 @@ _mesa_program_resource_find_name(struct gl_shader_program *shProg,
{
struct gl_program_resource *res = NULL;
if (name == NULL)
return NULL;
/* If we have a name, try the ProgramResourceHash first. */
if (name && shProg->data->ProgramResourceHash)
if (shProg->data->ProgramResourceHash)
res = search_resource_hash(shProg, programInterface, name, array_index);
if (res)