From 39ae85732d29906ea2a16dfdfc77f8e5dbed5853 Mon Sep 17 00:00:00 2001 From: Eduardo Lima Mitev Date: Mon, 2 Feb 2015 18:14:47 +0100 Subject: [PATCH] mesa: Fix error validating args for TexSubImage3D The zoffset and depth values were not being considered when calling error_check_subtexture_dimensions(). Fixes 2 dEQP tests: * dEQP-GLES3.functional.negative_api.texture.texsubimage3d_neg_offset * dEQP-GLES3.functional.negative_api.texture.texsubimage3d_invalid_offset Reviewed-by: Brian Paul Reviewed-by: Ian Romanick Cc: "10.4 10.5" (cherry picked from commit 2aa71e9485a5a062b1bd2dd8bdc081a8fa4c873d) [Emil Velikov: Resolve trivial conflicts] Signed-off-by: Emil Velikov Conflicts: src/mesa/main/teximage.c --- src/mesa/main/teximage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 7766904c91f..3c494be8209 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -2497,7 +2497,7 @@ texsubimage_error_check(struct gl_context *ctx, GLuint dimensions, } if (error_check_subtexture_dimensions(ctx, "glTexSubImage", dimensions, - texImage, xoffset, yoffset, 0, + texImage, xoffset, yoffset, zoffset, width, height, 1)) { return GL_TRUE; }