From 390cf7561068ac18ff7a48f5a461314e21fc7659 Mon Sep 17 00:00:00 2001 From: Valentine Burley Date: Fri, 15 Aug 2025 12:07:35 +0200 Subject: [PATCH] tu: Enable robustBufferAccessUpdateAfterBind This is supported and must be enabled when descriptorBinding*UpdateAfterBind is active. Fixes the following VVL error: Validation Error: [ VUID-VkDeviceCreateInfo-robustBufferAccess-10247 ] vkCreateDevice(): robustBufferAccessUpdateAfterBind is false, but both robustBufferAccess and a descriptorBinding*UpdateAfterBind feature are enabled. Fixes: d9fcf5de55a ("turnip: Enable nonuniform descriptor indexing") Signed-off-by: Valentine Burley Part-of: (cherry picked from commit 31f6235126b8d6d1f3c8afce86e61af0d92be2f0) --- .pick_status.json | 2 +- src/freedreno/vulkan/tu_device.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index d548e1245bf..d1eb12bc009 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -8624,7 +8624,7 @@ "description": "tu: Enable robustBufferAccessUpdateAfterBind", "nominated": true, "nomination_type": 2, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "d9fcf5de55a7104037823e62284ace8a206c8898", "notes": null diff --git a/src/freedreno/vulkan/tu_device.cc b/src/freedreno/vulkan/tu_device.cc index 2c72aff780d..2f5e07bec54 100644 --- a/src/freedreno/vulkan/tu_device.cc +++ b/src/freedreno/vulkan/tu_device.cc @@ -893,7 +893,7 @@ tu_get_physical_device_properties_1_2(struct tu_physical_device *pdevice, p->shaderStorageBufferArrayNonUniformIndexingNative = true; p->shaderStorageImageArrayNonUniformIndexingNative = true; p->shaderInputAttachmentArrayNonUniformIndexingNative = false; - p->robustBufferAccessUpdateAfterBind = false; + p->robustBufferAccessUpdateAfterBind = true; p->quadDivergentImplicitLod = false; p->maxUpdateAfterBindDescriptorsInAllPools = max_descriptor_set_size;