From 38950083ae9fe5650150614687c7c46342d71d02 Mon Sep 17 00:00:00 2001 From: Faith Ekstrand Date: Tue, 21 Oct 2025 10:11:03 -0400 Subject: [PATCH] panvk: Fix integer dot product properties We already set has_[su]dot_4x8[_sat] in nir_shader_compiler_options so we're already getting the opcodes. We just need to advertise the features properly. If bifrost_compile.h is to be believed, those are all available starting at gen 9. Closes: https://gitlab.freedesktop.org/panfrost/mesa/-/issues/218 Closes: https://gitlab.freedesktop.org/panfrost/mesa/-/issues/219 Fixes: f7f9b3d170f5 ("panvk: Move to vk_properties") Reviewed-by: Mary Guillemard Reviewed-by: Lars-Ivar Hesselberg Simonsen Part-of: --- src/panfrost/vulkan/panvk_vX_physical_device.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/panfrost/vulkan/panvk_vX_physical_device.c b/src/panfrost/vulkan/panvk_vX_physical_device.c index 219eeab7da1..69bdc512eea 100644 --- a/src/panfrost/vulkan/panvk_vX_physical_device.c +++ b/src/panfrost/vulkan/panvk_vX_physical_device.c @@ -922,12 +922,11 @@ panvk_per_arch(get_physical_device_properties)( MAX_INLINE_UNIFORM_BLOCK_DESCRIPTORS, .maxInlineUniformTotalSize = MAX_INLINE_UNIFORM_BLOCK_DESCRIPTORS * MAX_INLINE_UNIFORM_BLOCK_SIZE, - .integerDotProduct8BitUnsignedAccelerated = true, - .integerDotProduct8BitSignedAccelerated = true, + .integerDotProduct8BitUnsignedAccelerated = false, + .integerDotProduct8BitSignedAccelerated = false, .integerDotProduct8BitMixedSignednessAccelerated = false, - .integerDotProduct4x8BitPackedUnsignedAccelerated = true, - .integerDotProduct4x8BitPackedSignedAccelerated = true, - .integerDotProduct4x8BitPackedSignedAccelerated = false, + .integerDotProduct4x8BitPackedUnsignedAccelerated = PAN_ARCH >= 9, + .integerDotProduct4x8BitPackedSignedAccelerated = PAN_ARCH >= 9, .integerDotProduct16BitUnsignedAccelerated = false, .integerDotProduct16BitSignedAccelerated = false, .integerDotProduct16BitMixedSignednessAccelerated = false, @@ -940,8 +939,8 @@ panvk_per_arch(get_physical_device_properties)( .integerDotProductAccumulatingSaturating8BitUnsignedAccelerated = false, .integerDotProductAccumulatingSaturating8BitSignedAccelerated = false, .integerDotProductAccumulatingSaturating8BitMixedSignednessAccelerated = false, - .integerDotProductAccumulatingSaturating4x8BitPackedUnsignedAccelerated = false, - .integerDotProductAccumulatingSaturating4x8BitPackedSignedAccelerated = false, + .integerDotProductAccumulatingSaturating4x8BitPackedUnsignedAccelerated = PAN_ARCH >= 9, + .integerDotProductAccumulatingSaturating4x8BitPackedSignedAccelerated = PAN_ARCH >= 9, .integerDotProductAccumulatingSaturating4x8BitPackedMixedSignednessAccelerated = false, .integerDotProductAccumulatingSaturating16BitUnsignedAccelerated = false, .integerDotProductAccumulatingSaturating16BitSignedAccelerated = false,