fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-21 09:20:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

anv: flush pipeline before query result copies

Browse source 
Pipeline state pending bits should be taken into account when copying
results.

In the particular bug below, the results of the
vkCmdCopyQueryPoolResults() command was being overwritten by the
preceding vkCmdCopyBuffer() with a same destination buffer. This is
because we copy the buffers using the 3D pipeline whereas we copy the
query results using the command streamer. Those pieces of HW work in
parallel and the results are somewhat undefined.

v2: Unconditionally flush the pipeline before copying the results
    (Jason)

v3: Wrap & expressions (Jason)

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Suggested-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108894
Cc: mesa-stable@lists.freedesktop.org
This commit is contained in:
Lionel Landwerlin 2018-11-29 13:02:03 +00:00
parent 39b20b7d4f
commit 37f9788e9a
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/intel/vulkan/genX_query.c
View file

@ -729,11 +729,10 @@ void genX(CmdCopyQueryPoolResults)(
ANV_FROM_HANDLE(anv_query_pool, pool, queryPool); ANV_FROM_HANDLE(anv_query_pool, pool, queryPool);
ANV_FROM_HANDLE(anv_buffer, buffer, destBuffer); ANV_FROM_HANDLE(anv_buffer, buffer, destBuffer);
if (flags & VK_QUERY_RESULT_WAIT_BIT) { if ((flags & VK_QUERY_RESULT_WAIT_BIT) ||
anv_batch_emit(&cmd_buffer->batch, GENX(PIPE_CONTROL), pc) { (cmd_buffer->state.pending_pipe_bits & ANV_PIPE_FLUSH_BITS)) {
pc.CommandStreamerStallEnable = true; cmd_buffer->state.pending_pipe_bits |= ANV_PIPE_CS_STALL_BIT;
pc.StallAtPixelScoreboard = true; genX(cmd_buffer_apply_pipe_flushes)(cmd_buffer);
}
} }
struct anv_address dest_addr = anv_address_add(buffer->address, destOffset); struct anv_address dest_addr = anv_address_add(buffer->address, destOffset);