fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-06 02:58:05 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

mesa: restructure bind_buffer_object for better performance

Browse source 
The CPU time spent in _mesa_BindBuffer_no_error decresed from 11.4% to 9.2%.
I explain in the code what is happening here because it's not obvious.

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18828>
This commit is contained in:
Marek Olšák 2022-08-22 01:40:35 -04:00 • committed by Marge Bot
parent 6a1ede73f5
commit 37421a24ad
1 changed files with 21 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
src/mesa/main/bufferobj.c
View file

@ -1349,29 +1349,33 @@ bind_buffer_object(struct gl_context *ctx,
bool no_error)
{
struct gl_buffer_object *oldBufObj;
struct gl_buffer_object *newBufObj = NULL;
struct gl_buffer_object *newBufObj;
assert(bindTarget);
/* Get pointer to old buffer object (to be unbound) */
oldBufObj = *bindTarget;
if ((oldBufObj && oldBufObj->Name == buffer && !oldBufObj->DeletePending) ||
(!oldBufObj && buffer == 0))
return; /* rebinding the same buffer object- no change */
/*
* Get pointer to new buffer object (newBufObj)
/* Fast path that unbinds. It's better when NULL is a literal, so that
* the compiler can simplify this code after inlining.
*/
if (buffer != 0) {
/* non-default buffer object */
newBufObj = _mesa_lookup_bufferobj(ctx, buffer);
if (!_mesa_handle_bind_buffer_gen(ctx, buffer,
&newBufObj, "glBindBuffer",
no_error))
return;
if (buffer == 0) {
_mesa_reference_buffer_object(ctx, bindTarget, NULL);
return;
}
/* bind new buffer */
/* Get pointer to old buffer object (to be unbound) */
oldBufObj = *bindTarget;
GLuint old_name = oldBufObj && !oldBufObj->DeletePending ? oldBufObj->Name : 0;
if (old_name == buffer)
return; /* rebinding the same buffer object- no change */
newBufObj = _mesa_lookup_bufferobj(ctx, buffer);
/* Get a new buffer object if it hasn't been created. */
if (!handle_bind_buffer_gen(ctx, buffer, &newBufObj, "glBindBuffer",
no_error))
return;
/* At this point, the compiler should deduce that newBufObj is non-NULL if
* everything has been inlined, so the compiler should simplify this.
*/
_mesa_reference_buffer_object(ctx, bindTarget, newBufObj);
}