fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 07:28:11 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

freedreno/registers: Clarify bit 64B of CP_REG_TO_MEM

Browse source 
One might think that the `64B` bit might be affecting just the
memory size, but that's not the case as it affects the register
count too. Setting `64B` with `CNT` of `1` actually copies 2
registers, and not 1.

Signed-off-by: Karmjit Mahil <karmjit.mahil@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38535>
This commit is contained in:
Karmjit Mahil 2025-11-19 17:00:52 +00:00 • committed by Marge Bot
parent 9c34567a4a
commit 36f6cf8a35
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/freedreno/registers/adreno/adreno_pm4.xml
View file

@ -1269,8 +1269,15 @@ opcode: CP_LOAD_STATE4 (30) (4 dwords)
<domain name="CP_REG_TO_MEM" width="32" prefix="chip">
<reg32 offset="0" name="0">
<bitfield name="REG" low="0" high="17" type="hex"/>
<!-- number of registers/dwords copied is max(CNT, 1). -->
<!--
Number of registers/dwords copied is max(CNT, 1).
With 64B it gets rounded to the next 64B boundary.
-->
<bitfield name="CNT" low="18" high="29" type="uint"/>
<!--
Treat things as 64B, allowing for a 64B atomic read of
registers.
-->
<bitfield name="64B" pos="30" type="boolean"/>
<bitfield name="ACCUMULATE" pos="31" type="boolean"/>
</reg32>