fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-23 22:00:13 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

intel/decoder: add assert for register size

Browse source 
Coverity complains about out-of-bounds access in
intel_field_iterator_init, because it doesn't know that the GT_MODE
register has a size of 4 bytes. Add an assertion to verify that.

CID: 1474552

Signed-off-by: Marcin Ślusarz <marcin.slusarz@intel.com>
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11574>
This commit is contained in:
Marcin Ślusarz 2021-06-24 11:30:03 +02:00 • committed by Marge Bot
parent 11528b621c
commit 365c7cc87c
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/intel/common/intel_batch_decoder.c
View file

@ -927,6 +927,8 @@ handle_gt_mode(struct intel_batch_decode_ctx *ctx,
{ {
struct intel_group *reg = intel_spec_find_register(ctx->spec, reg_addr); struct intel_group *reg = intel_spec_find_register(ctx->spec, reg_addr);
assert(intel_group_get_length(reg, &val) == 1);
struct intel_field_iterator iter; struct intel_field_iterator iter;
intel_field_iterator_init(&iter, reg, &val, 0, false); intel_field_iterator_init(&iter, reg, &val, 0, false);