fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 11:18:08 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

r300: bias presubtract fix

Browse source 
We need to double check that the source is indeed constant before
looking at the constant type.

Signed-off-by: Pavel Ondračka <pavel.ondracka@gmail.com>
Fixes: 0508db9155
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29893>
(cherry picked from commit 1cad339409)
This commit is contained in:
Pavel Ondračka 2024-06-25 11:27:47 +02:00 • committed by Eric Engestrom
parent 6fca3cd058
commit 34b1102390
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -924,7 +924,7 @@
"description": "r300: bias presubtract fix",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "0508db91556242c57029ad538613c2b1ee1969ef",
"notes": null

5
src/gallium/drivers/r300/compiler/radeon_optimize.c
View file

@ -627,7 +627,10 @@ static int peephole_mad_presub_bias(
if (rc_inline_to_float(src1_reg.Index) != 2.0f)
return 0;
} else {
struct rc_constant *constant = &c->Program.Constants.Constants[src1_reg.Index];
if (src1_reg.File != RC_FILE_CONSTANT)
return 0;
struct rc_constant *constant = &c->Program.Constants.Constants[src1_reg.Index];
if (constant->Type != RC_CONSTANT_IMMEDIATE)
return 0;
for (i = 0; i < 4; i++) {