ilo: print a warning when PPGTT is disabled

Despite what the PRMs say, the driver appears to work fine when PPGTT is
disabled.  But at least print a warning in that case.
This commit is contained in:
Chia-I Wu 2014-03-10 12:40:29 +08:00
parent 747627d045
commit 345bf92f13
4 changed files with 24 additions and 0 deletions

View file

@ -72,6 +72,7 @@ struct ilo_dev_info {
bool has_llc;
bool has_address_swizzling;
bool has_logical_context;
bool has_ppgtt;
bool has_timestamp;
bool has_gen7_sol_reset;

View file

@ -652,6 +652,7 @@ init_dev(struct ilo_dev_info *dev, const struct intel_winsys_info *info)
dev->has_llc = info->has_llc;
dev->has_address_swizzling = info->has_address_swizzling;
dev->has_logical_context = info->has_logical_context;
dev->has_ppgtt = info->has_ppgtt;
dev->has_timestamp = info->has_timestamp;
dev->has_gen7_sol_reset = info->has_gen7_sol_reset;
@ -660,6 +661,24 @@ init_dev(struct ilo_dev_info *dev, const struct intel_winsys_info *info)
return false;
}
/*
* PIPE_CONTROL and MI_* use PPGTT writes on GEN7+ and privileged GGTT
* writes on GEN6.
*
* From the Sandy Bridge PRM, volume 1 part 3, page 101:
*
* "[DevSNB] When Per-Process GTT Enable is set, it is assumed that all
* code is in a secure environment, independent of address space.
* Under this condition, this bit only specifies the address space
* (GGTT or PPGTT). All commands are executed "as-is""
*
* We need PPGTT to be enabled on GEN6 too.
*/
if (!dev->has_ppgtt) {
/* experiments show that it does not really matter... */
ilo_warn("PPGTT disabled\n");
}
/*
* From the Sandy Bridge PRM, volume 4 part 2, page 18:
*

View file

@ -149,6 +149,9 @@ probe_winsys(struct intel_winsys *winsys)
winsys->first_gem_ctx = drm_intel_gem_context_create(winsys->bufmgr);
info->has_logical_context = (winsys->first_gem_ctx != NULL);
get_param(winsys, I915_PARAM_HAS_ALIASING_PPGTT, &val);
info->has_ppgtt = val;
/* test TIMESTAMP read */
info->has_timestamp = test_reg_read(winsys, 0x2358);

View file

@ -73,6 +73,7 @@ struct intel_winsys_info {
bool has_llc;
bool has_address_swizzling;
bool has_logical_context;
bool has_ppgtt;
/* valid registers for intel_winsys_read_reg() */
bool has_timestamp;