diff --git a/.pick_status.json b/.pick_status.json index 7d036f664a8..18faa314612 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -2904,7 +2904,7 @@ "description": "hk: Use aligned vector fill in hk_CmdFillBuffer if possible", "nominated": false, "nomination_type": 0, - "resolution": 4, + "resolution": 1, "main_sha": null, "because_sha": null, "notes": null diff --git a/src/asahi/vulkan/hk_cmd_meta.c b/src/asahi/vulkan/hk_cmd_meta.c index a89255c3f60..abe4eb7d9c4 100644 --- a/src/asahi/vulkan/hk_cmd_meta.c +++ b/src/asahi/vulkan/hk_cmd_meta.c @@ -1493,7 +1493,12 @@ hk_CmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, uint64_t addr = vk_meta_buffer_address(&dev->vk, dstBuffer, dstOffset, dstRange); - libagx_fill(cmd, agx_1d(range / 4), AGX_BARRIER_ALL, addr, data); + if (util_is_aligned(addr, 16) && util_is_aligned(range, 16)) { + libagx_fill_uint4(cmd, agx_2d(range / 16, 1), AGX_BARRIER_ALL, + addr, 0, data, data, data, data); + } else { + libagx_fill(cmd, agx_1d(range / 4), AGX_BARRIER_ALL, addr, data); + } } VKAPI_ATTR void VKAPI_CALL