fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 09:08:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

pan/compiler: Fix progress reporting in pan_nir_lower_store_component

Browse source 
lower_store_component() always returns false even though it modifies
NIR instructions (rewrites sources, creates new SSA defs, removes
previous stores). This triggers the "NIR changed but no progress
reported" assertion in nir_shader_intrinsics_pass.

Return true when a store_output or store_per_view_output intrinsic is
processed, since the function always modifies the shader in that case.

Closes: https://gitlab.freedesktop.org/panfrost/mesa/-/issues/274
Cc: mesa-stable
Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com>
Reviewed-by: Daniel Stone <daniels@collabora.com>
(cherry picked from commit 4938ad435e)

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/39969>
This commit is contained in:
Christian Gmeiner 2026-02-07 23:41:54 +01:00 • committed by Dylan Baker
parent c78d272958
commit 32aa33606e
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -1254,7 +1254,7 @@
"description": "pan/compiler: Fix progress reporting in pan_nir_lower_store_component",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": null,
"notes": null

2
src/panfrost/util/pan_lower_store_component.c
View file

@ -90,7 +90,7 @@ lower_store_component(nir_builder *b, nir_intrinsic_instr *intr, void *data)
}
_mesa_hash_table_u64_insert(slots, slot, intr);
return false;
return true;
}
bool