fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-09 04:38:03 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

panfrost: Cleanup tiling selection logic

Browse source 
Make it a lot more obvious what we're doing and fix more than a few
corner cases in the process.

Fixes
dEQP-GLES3.functional.buffer.map.write.render_as_index_array.pixel*, and
likely others.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
This commit is contained in:
Alyssa Rosenzweig 2020-01-04 13:00:50 -05:00
parent dadfca3775
commit 32851ff715
1 changed files with 14 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
src/gallium/drivers/panfrost/pan_resource.c
View file

@ -389,28 +389,29 @@ panfrost_resource_create_bo(struct panfrost_screen *screen, struct panfrost_reso
* AFBC: Compressed and renderable (so always desirable for non-scanout
* rendertargets). Cheap to sample from. The format is black box, so we
* can't read/write from software.
*/
*
* Tiling textures is almost always faster, unless we only use it once.
* Only a few types of resources can be tiled, ensure the bind is only
* (a combination of) one of the following */
/* Tiling textures is almost always faster, unless we only use it once */
const unsigned valid_binding =
PIPE_BIND_RENDER_TARGET |
PIPE_BIND_BLENDABLE |
PIPE_BIND_SAMPLER_VIEW |
PIPE_BIND_DISPLAY_TARGET;
bool is_texture = (res->bind & PIPE_BIND_SAMPLER_VIEW);
bool is_2d = res->depth0 == 1 && res->array_size == 1;
bool is_streaming = (res->usage != PIPE_USAGE_STREAM);
bool is_global = res->bind & PIPE_BIND_GLOBAL;
bool should_tile = is_streaming && is_texture && is_2d && !is_global;
/* Depth/stencil can't be tiled, only linear or AFBC */
should_tile &= !(res->bind & PIPE_BIND_DEPTH_STENCIL);
bool is_2d = (res->target == PIPE_TEXTURE_2D);
bool should_tile = (res->usage != PIPE_USAGE_STREAM);
bool can_tile = is_2d && ((res->bind & ~valid_binding) == 0);
/* FBOs we would like to checksum, if at all possible */
bool can_checksum = !(res->bind & (PIPE_BIND_SCANOUT | PIPE_BIND_SHARED));
bool can_checksum = !(res->bind & ~valid_binding);
bool should_checksum = res->bind & PIPE_BIND_RENDER_TARGET;
pres->checksummed = can_checksum && should_checksum;
/* Set the layout appropriately */
pres->layout = should_tile ? PAN_TILED : PAN_LINEAR;
pres->layout = (can_tile && should_tile) ? PAN_TILED : PAN_LINEAR;
size_t bo_size;