fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-22 11:20:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

spirv, radv, anv: Replace ptr_type with addr_format

Browse source 
Instead of setting the glsl types of the pointers for each resource,
set the nir_address_format, from which we can derive the glsl_type,
and in the future the bit pattern representing a NULL pointer.

Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
This commit is contained in:
Caio Marcelo de Oliveira Filho 2019-05-01 14:15:32 -07:00
parent 6bc9cdb1b7
commit 31a7476335
5 changed files with 46 additions and 36 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/amd/vulkan/radv_shader.c
View file

@ -284,11 +284,11 @@ radv_shader_compile_to_nir(struct radv_device *device,
.trinary_minmax = true, .trinary_minmax = true,
.variable_pointers = true, .variable_pointers = true,
}, },
.ubo_ptr_type = glsl_vector_type(GLSL_TYPE_UINT, 2), .ubo_addr_format = nir_address_format_32bit_index_offset,
.ssbo_ptr_type = glsl_vector_type(GLSL_TYPE_UINT, 2), .ssbo_addr_format = nir_address_format_32bit_index_offset,
.phys_ssbo_ptr_type = glsl_vector_type(GLSL_TYPE_UINT64, 1), .phys_ssbo_addr_format = nir_address_format_64bit_global,
.push_const_ptr_type = glsl_uint_type(), .push_const_addr_format = nir_address_format_logical,
.shared_ptr_type = glsl_uint_type(), .shared_addr_format = nir_address_format_32bit_offset,
}; };
entry_point = spirv_to_nir(spirv, module->size / 4, entry_point = spirv_to_nir(spirv, module->size / 4,
spec_entries, num_spec_entries, spec_entries, num_spec_entries,

16
src/compiler/spirv/nir_spirv.h
View file

@ -72,14 +72,14 @@ struct spirv_to_nir_options {
struct spirv_supported_capabilities caps; struct spirv_supported_capabilities caps;
/* Storage types for various kinds of pointers. */ /* Address format for various kinds of pointers. */
const struct glsl_type *ubo_ptr_type; nir_address_format ubo_addr_format;
const struct glsl_type *ssbo_ptr_type; nir_address_format ssbo_addr_format;
const struct glsl_type *phys_ssbo_ptr_type; nir_address_format phys_ssbo_addr_format;
const struct glsl_type *push_const_ptr_type; nir_address_format push_const_addr_format;
const struct glsl_type *shared_ptr_type; nir_address_format shared_addr_format;
const struct glsl_type *global_ptr_type; nir_address_format global_addr_format;
const struct glsl_type *temp_ptr_type; nir_address_format temp_addr_format;
struct { struct {
void (*func)(void *private_data, void (*func)(void *private_data,

30
src/compiler/spirv/spirv_to_nir.c
View file

@ -1364,36 +1364,38 @@ vtn_handle_type(struct vtn_builder *b, SpvOp opcode,
/* These can actually be stored to nir_variables and used as SSA /* These can actually be stored to nir_variables and used as SSA
* values so they need a real glsl_type. * values so they need a real glsl_type.
*/ */
nir_address_format addr_format = nir_address_format_logical;
switch (storage_class) { switch (storage_class) {
case SpvStorageClassUniform: case SpvStorageClassUniform:
val->type->type = b->options->ubo_ptr_type; addr_format = b->options->ubo_addr_format;
break; break;
case SpvStorageClassStorageBuffer: case SpvStorageClassStorageBuffer:
val->type->type = b->options->ssbo_ptr_type; addr_format = b->options->ssbo_addr_format;
break; break;
case SpvStorageClassPhysicalStorageBufferEXT: case SpvStorageClassPhysicalStorageBufferEXT:
val->type->type = b->options->phys_ssbo_ptr_type; addr_format = b->options->phys_ssbo_addr_format;
break; break;
case SpvStorageClassPushConstant: case SpvStorageClassPushConstant:
val->type->type = b->options->push_const_ptr_type; addr_format = b->options->push_const_addr_format;
break; break;
case SpvStorageClassWorkgroup: case SpvStorageClassWorkgroup:
val->type->type = b->options->shared_ptr_type; addr_format = b->options->shared_addr_format;
break; break;
case SpvStorageClassCrossWorkgroup: case SpvStorageClassCrossWorkgroup:
val->type->type = b->options->global_ptr_type; addr_format = b->options->global_addr_format;
break; break;
case SpvStorageClassFunction: case SpvStorageClassFunction:
if (b->physical_ptrs) if (b->physical_ptrs)
val->type->type = b->options->temp_ptr_type; addr_format = b->options->temp_addr_format;
break; break;
default: default:
/* In this case, no variable pointers are allowed so all deref /* In this case, no variable pointers are allowed so all deref
* chains are complete back to the variable and it doesn't matter * chains are complete back to the variable and it doesn't matter
* what type gets used so we leave it NULL. * what type gets.
*/ */
break; break;
} }
val->type->type = nir_address_format_to_glsl_type(addr_format);
} else { } else {
vtn_fail_if(val->type->storage_class != storage_class, vtn_fail_if(val->type->storage_class != storage_class,
"The storage classes of an OpTypePointer and any " "The storage classes of an OpTypePointer and any "
@ -3774,18 +3776,18 @@ vtn_handle_preamble_instruction(struct vtn_builder *b, SpvOp opcode,
"AddressingModelPhysical32 only supported for kernels"); "AddressingModelPhysical32 only supported for kernels");
b->shader->info.cs.ptr_size = 32; b->shader->info.cs.ptr_size = 32;
b->physical_ptrs = true; b->physical_ptrs = true;
b->options->shared_ptr_type = glsl_uint_type(); b->options->shared_addr_format = nir_address_format_32bit_global;
b->options->global_ptr_type = glsl_uint_type(); b->options->global_addr_format = nir_address_format_32bit_global;
b->options->temp_ptr_type = glsl_uint_type(); b->options->temp_addr_format = nir_address_format_32bit_global;
break; break;
case SpvAddressingModelPhysical64: case SpvAddressingModelPhysical64:
vtn_fail_if(b->shader->info.stage != MESA_SHADER_KERNEL, vtn_fail_if(b->shader->info.stage != MESA_SHADER_KERNEL,
"AddressingModelPhysical64 only supported for kernels"); "AddressingModelPhysical64 only supported for kernels");
b->shader->info.cs.ptr_size = 64; b->shader->info.cs.ptr_size = 64;
b->physical_ptrs = true; b->physical_ptrs = true;
b->options->shared_ptr_type = glsl_uint64_t_type(); b->options->shared_addr_format = nir_address_format_64bit_global;
b->options->global_ptr_type = glsl_uint64_t_type(); b->options->global_addr_format = nir_address_format_64bit_global;
b->options->temp_ptr_type = glsl_uint64_t_type(); b->options->temp_addr_format = nir_address_format_64bit_global;
break; break;
case SpvAddressingModelLogical: case SpvAddressingModelLogical:
vtn_fail_if(b->shader->info.stage >= MESA_SHADER_STAGES, vtn_fail_if(b->shader->info.stage >= MESA_SHADER_STAGES,

8
src/compiler/spirv/vtn_variables.c
View file

@ -99,14 +99,18 @@ vk_desc_type_for_mode(struct vtn_builder *b, enum vtn_variable_mode mode)
static const struct glsl_type * static const struct glsl_type *
vtn_ptr_type_for_mode(struct vtn_builder *b, enum vtn_variable_mode mode) vtn_ptr_type_for_mode(struct vtn_builder *b, enum vtn_variable_mode mode)
{ {
nir_address_format addr_format;
switch (mode) { switch (mode) {
case vtn_variable_mode_ubo: case vtn_variable_mode_ubo:
return b->options->ubo_ptr_type; addr_format = b->options->ubo_addr_format;
break;
case vtn_variable_mode_ssbo: case vtn_variable_mode_ssbo:
return b->options->ssbo_ptr_type; addr_format = b->options->ssbo_addr_format;
break;
default: default:
vtn_fail("Invalid mode for vulkan_resource_index"); vtn_fail("Invalid mode for vulkan_resource_index");
} }
return nir_address_format_to_glsl_type(addr_format);
} }
static nir_ssa_def * static nir_ssa_def *

18
src/intel/vulkan/anv_pipeline.c
View file

@ -134,8 +134,6 @@ anv_shader_compile_to_nir(struct anv_device *device,
} }
} }
nir_address_format ssbo_addr_format =
anv_nir_ssbo_addr_format(pdevice, device->robust_buffer_access);
struct spirv_to_nir_options spirv_options = { struct spirv_to_nir_options spirv_options = {
.lower_workgroup_access_to_offsets = true, .lower_workgroup_access_to_offsets = true,
.caps = { .caps = {
@ -172,11 +170,17 @@ anv_shader_compile_to_nir(struct anv_device *device,
.transform_feedback = pdevice->info.gen >= 8, .transform_feedback = pdevice->info.gen >= 8,
.variable_pointers = true, .variable_pointers = true,
}, },
.ubo_ptr_type = glsl_vector_type(GLSL_TYPE_UINT, 2), .ubo_addr_format = nir_address_format_32bit_index_offset,
.ssbo_ptr_type = nir_address_format_to_glsl_type(ssbo_addr_format), .ssbo_addr_format =
.phys_ssbo_ptr_type = glsl_vector_type(GLSL_TYPE_UINT64, 1), anv_nir_ssbo_addr_format(pdevice, device->robust_buffer_access),
.push_const_ptr_type = glsl_uint_type(), .phys_ssbo_addr_format = nir_address_format_64bit_global,
.shared_ptr_type = glsl_uint_type(), .push_const_addr_format = nir_address_format_logical,
/* TODO: Consider changing this to an address format that has the NULL
* pointer equals to 0. That might be a better format to play nice
* with certain code / code generators.
*/
.shared_addr_format = nir_address_format_32bit_offset,
}; };