From 316d9b02098598c5671ddab2f649c279117f7989 Mon Sep 17 00:00:00 2001 From: Valentine Burley Date: Thu, 19 Mar 2026 20:01:13 +0100 Subject: [PATCH] tu/drm/virtio: Fix GEM handle leak in tu_bo_init error path In tu_bo_init, if growing the submit BO list fails, the GEM handle must be closed. However, bo->gem_handle is only populated later via compound assignment. Use the gem_handle parameter directly to ensure the correct handle is closed and not leaked. Fixes: d67d501af46 ("tu/drm/virtio: Switch to vdrm helper") Signed-off-by: Valentine Burley Part-of: --- src/freedreno/vulkan/tu_knl_drm_virtio.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/freedreno/vulkan/tu_knl_drm_virtio.cc b/src/freedreno/vulkan/tu_knl_drm_virtio.cc index df1a016c2fa..1139689bb66 100644 --- a/src/freedreno/vulkan/tu_knl_drm_virtio.cc +++ b/src/freedreno/vulkan/tu_knl_drm_virtio.cc @@ -593,7 +593,7 @@ tu_bo_init(struct tu_device *dev, if (!new_ptr) { dev->submit_bo_count--; mtx_unlock(&dev->bo_mutex); - vdrm_bo_close(dev->vdev->vdrm, bo->gem_handle); + vdrm_bo_close(dev->vdev->vdrm, gem_handle); return VK_ERROR_OUT_OF_HOST_MEMORY; }