From 30c2e6dbf2cd01f16a445647be15c8c98aac8165 Mon Sep 17 00:00:00 2001 From: Eric Engestrom Date: Fri, 16 Jan 2026 14:25:40 +0100 Subject: [PATCH] nir/meson: drop redundant --build-tests in favour of just checking if --out-tests is set Part-of: --- src/compiler/nir/meson.build | 2 +- src/compiler/nir/nir_opt_algebraic.py | 20 +++++++++----------- 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/src/compiler/nir/meson.build b/src/compiler/nir/meson.build index 19aed0f72f1..0a190401c28 100644 --- a/src/compiler/nir/meson.build +++ b/src/compiler/nir/meson.build @@ -46,7 +46,7 @@ nir_opt_algebraic = custom_target( input : 'nir_opt_algebraic.py', output : ['nir_opt_algebraic.c'] + (with_tests ? ['nir_opt_algebraic_pattern_test.cpp'] : []), command : [prog_python, '@INPUT@', '--out', '@OUTPUT0@'] + - (with_tests ? ['--build-tests', '--out-tests', '@OUTPUT1@'] : []), + (with_tests ? ['--out-tests', '@OUTPUT1@'] : []), depend_files : nir_algebraic_depends, ) nir_opt_algebraic_c = nir_opt_algebraic[0] diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compiler/nir/nir_opt_algebraic.py index c1a59ddcfdf..6c17e14365b 100644 --- a/src/compiler/nir/nir_opt_algebraic.py +++ b/src/compiler/nir/nir_opt_algebraic.py @@ -4283,57 +4283,55 @@ for s in [8, 16]: parser = argparse.ArgumentParser() parser.add_argument('--out', required=True) parser.add_argument('--out-tests') -parser.add_argument('--build-tests', action='store_true') args = parser.parse_args() -if args.build_tests and not args.out_tests: - parser.error("--build-tests requires --out-tests") +build_tests = args.out_tests is not None passes = [] passes.append(nir_algebraic.AlgebraicPass( "nir_opt_algebraic", optimizations, - build_tests=args.build_tests + build_tests=build_tests )) passes.append(nir_algebraic.AlgebraicPass( "nir_opt_algebraic_before_ffma", before_ffma_optimizations, - build_tests=args.build_tests + build_tests=build_tests )) passes.append(nir_algebraic.AlgebraicPass( "nir_opt_algebraic_before_lower_int64", before_lower_int64_optimizations, - build_tests=args.build_tests + build_tests=build_tests )) passes.append(nir_algebraic.AlgebraicPass( "nir_opt_algebraic_late", late_optimizations, - build_tests=args.build_tests + build_tests=build_tests )) passes.append(nir_algebraic.AlgebraicPass( "nir_opt_algebraic_distribute_src_mods", distribute_src_mods, - build_tests=args.build_tests + build_tests=build_tests )) passes.append(nir_algebraic.AlgebraicPass( "nir_opt_algebraic_integer_promotion", integer_promotion_optimizations, - build_tests=args.build_tests + build_tests=build_tests )) passes.append(nir_algebraic.AlgebraicPass( "nir_opt_reassociate_matrix_mul", mat_mul_optimizations, - build_tests=args.build_tests + build_tests=build_tests )) -if args.build_tests: +if build_tests: with open(args.out_tests, "w", encoding='utf-8') as f: for p in passes: f.write(p.render_tests())