fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 13:58:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

pan/mdg: Remove uppercase write masks

Browse source 
These do not convey any additional information, and fail to account for
shrinking. In particular, a 64-bit writemask with .keephi would fail to
disassemble and instead trip the assertion, since that would be the ZW
components. Just delete the broken code.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16798>
(cherry picked from commit 8c11f4809b)
This commit is contained in:
Alyssa Rosenzweig 2022-05-19 12:08:46 -04:00 • committed by Dylan Baker
parent 01eba9dcb2
commit 30a9514258
2 changed files with 1 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -2767,7 +2767,7 @@
"description": "pan/mdg: Remove uppercase write masks",
"nominated": true,
"nomination_type": 0,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": null
},

6
src/panfrost/midgard/disassemble.c
View file

@ -737,7 +737,6 @@ print_alu_mask(FILE *fp, uint8_t mask, unsigned bits, midgard_shrink_mode shrink
fprintf(fp, ".");
unsigned skip = MAX2(bits / 16, 1);
bool uppercase = bits > 32;
bool tripped = false;
/* To apply an upper destination shrink_mode, we "shift" the alphabet.
@ -764,11 +763,6 @@ print_alu_mask(FILE *fp, uint8_t mask, unsigned bits, midgard_shrink_mode shrink
unsigned comp_idx = bits == 8 ? i * 2 : i;
char c = alphabet[comp_idx / skip];
if (uppercase) {
c = toupper(c);
assert(c == 'X' || c == 'Y');
}
fprintf(fp, "%c", c);
if (bits == 8)
fprintf(fp, "%c", alphabet[comp_idx+1]);