fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-04 22:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

panfrost/drm: Don't mmap INVISIBLE buffers

Browse source 
On the new kernel, mmaping doesn't *hurt* per se, but it's still
wasteful for buffers explicitly marked as not needing an mmap.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
This commit is contained in:
Alyssa Rosenzweig 2019-07-12 15:39:47 -07:00
parent c9c8c2f7d7
commit 2f783ede02
1 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/gallium/drivers/panfrost/pan_drm.c
View file

@ -88,9 +88,13 @@ panfrost_drm_create_bo(struct panfrost_screen *screen, size_t size,
/* Kernel will fail (confusingly) with EPERM otherwise */
assert(size > 0);
unsigned translated_flags = 0;
/* TODO: translate flags to kernel flags, if the kernel supports */
struct drm_panfrost_create_bo create_bo = {
.size = size,
.flags = flags,
.flags = translated_flags,
};
int ret;
@ -104,8 +108,12 @@ panfrost_drm_create_bo(struct panfrost_screen *screen, size_t size,
bo->gpu = create_bo.offset;
bo->gem_handle = create_bo.handle;
// TODO map and unmap on demand?
panfrost_drm_mmap_bo(screen, bo);
/* Only mmap now if we know we need to. For CPU-invisible buffers, we
* never map since we don't care about their contents; they're purely
* for GPU-internal use. */
if (!(flags & PAN_ALLOCATE_INVISIBLE))
panfrost_drm_mmap_bo(screen, bo);
pipe_reference_init(&bo->reference, 1);
return bo;
@ -143,7 +151,7 @@ panfrost_drm_allocate_slab(struct panfrost_screen *screen,
// TODO cache allocations
// TODO properly handle errors
// TODO take into account extra_flags
mem->bo = panfrost_drm_create_bo(screen, pages * 4096, 0);
mem->bo = panfrost_drm_create_bo(screen, pages * 4096, extra_flags);
mem->stack_bottom = 0;
}