fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-04 01:08:03 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

mesa/st: Fix use-after-free of the draw VS.

Browse source 
If the program with a draw variant gets deleted, it could leave a dangling
pointer in st's draw module that would get referenced next state update of
a draw fallback.

Fixes a valgrind complaint in piglit's rasterpos test, which is flaky on
softpipe (but not due to this).

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8207>
This commit is contained in:
Eric Anholt 2020-12-22 16:42:49 -08:00 • committed by Marge Bot
parent 5dd5fb1926
commit 2f41afeac1
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/mesa/state_tracker/st_draw_feedback.c
View file

@ -518,4 +518,6 @@ st_feedback_draw_vbo(struct gl_context *ctx,
draw_set_mapped_vertex_buffer(draw, buf, NULL, 0);
}
draw_set_vertex_buffers(draw, 0, num_vbuffers, NULL);
draw_bind_vertex_shader(draw, NULL);
}