From 2f3d6119fc037156d0642b7ddbc45fe5a9f58234 Mon Sep 17 00:00:00 2001 From: Rob Clark Date: Wed, 17 Dec 2025 16:15:33 -0800 Subject: [PATCH] freedreno/registers: Move 'unknown' last If the builder is passed just a raw value, like an iova in the case of turnip, we probably don't want to assert that it is all unknown bits. This hasn't been a problem for the gallium driver, as the bo pointer is first. But became a problem for turnip with commit 2d6c15ad5755 ("tu: remove magic bo reg packing (use iovas directly)"). Signed-off-by: Rob Clark Part-of: --- src/freedreno/registers/gen_header.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/freedreno/registers/gen_header.py b/src/freedreno/registers/gen_header.py index d6aebdba6e6..33372108aaa 100644 --- a/src/freedreno/registers/gen_header.py +++ b/src/freedreno/registers/gen_header.py @@ -258,11 +258,11 @@ class Bitset(object): # Requires using `fui()` or `_mesa_float_to_half()` constexpr_mark = "" if reg.bit_size == 64: - tab_to(" uint64_t", "unknown;") tab_to(" uint64_t", "qword;") + tab_to(" uint64_t", "unknown;") else: - tab_to(" uint32_t", "unknown;") tab_to(" uint32_t", "dword;") + tab_to(" uint32_t", "unknown;") print("};\n") if not has_variants: