fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-04-05 14:40:34 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

asahi: clarify how unroll index buffers are offsetted

Browse source 
it's a little inconsistent

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28483>
This commit is contained in:
Alyssa Rosenzweig 2024-02-18 09:06:06 -04:00 • committed by Marge Bot
parent e952189443
commit 2f1b50d8bc
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/gallium/drivers/asahi/agx_state.c
View file

@ -4326,8 +4326,7 @@ agx_draw_without_restart(struct agx_batch *batch,
agx_batch_init_state(batch);
size_t ib_extent = 0;
uint64_t ib =
agx_index_buffer_ptr(batch, info, indirect ? NULL : draw, &ib_extent);
uint64_t ib;
/* The rest of this function handles only the general case of indirect
* multidraws, so synthesize an indexed indirect draw now if we need one for
@ -4336,6 +4335,9 @@ agx_draw_without_restart(struct agx_batch *batch,
struct pipe_draw_indirect_info indirect_synthesized = {.draw_count = 1};
if (!indirect) {
/* Adds in the offset so set to 0 in the desc */
ib = agx_index_buffer_direct_ptr(batch, draw, info, &ib_extent);
uint32_t desc[5] = {draw->count, info->instance_count, 0,
draw->index_bias, info->start_instance};
@ -4343,6 +4345,9 @@ agx_draw_without_restart(struct agx_batch *batch,
&indirect_synthesized.offset, &indirect_synthesized.buffer);
indirect = &indirect_synthesized;
} else {
/* Does not add in offset, the unroll kernel uses the desc's offset */
ib = agx_index_buffer_rsrc_ptr(batch, info, &ib_extent);
}
/* Next, we unroll the index buffer used by the indirect draw */