diff --git a/.pick_status.json b/.pick_status.json index 63ab64e108b..3409c2491da 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -256,7 +256,7 @@ "description": "mesa: fix crashes in the no_error path of glUniform", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "bd2662bfa1c8746dc29a7bad32a1647379f78532" }, diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index 206f6a86450..236c794b119 100644 --- a/src/mesa/main/uniform_query.cpp +++ b/src/mesa/main/uniform_query.cpp @@ -1280,7 +1280,7 @@ _mesa_uniform(GLint location, GLsizei count, const GLvoid *values, return; uni = shProg->UniformRemapTable[location]; - if (!uni) + if (!uni || uni == INACTIVE_UNIFORM_EXPLICIT_LOCATION) return; /* The array index specified by the uniform location is just the @@ -1846,6 +1846,8 @@ _mesa_uniform_handle(GLint location, GLsizei count, const GLvoid *values, return; uni = shProg->UniformRemapTable[location]; + if (!uni || uni == INACTIVE_UNIFORM_EXPLICIT_LOCATION) + return; /* The array index specified by the uniform location is just the * uniform location minus the base location of of the uniform.