fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-07 00:38:48 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

jay/assign_flags: don't burn a null flag

Browse source 
SIMD32:

   Totals from 423 (15.98% of 2647) affected shaders:
   Instrs: 740042 -> 736360 (-0.50%); split: -1.25%, +0.75%
   CodeSize: 11984176 -> 11925888 (-0.49%); split: -1.23%, +0.74%
   Number of spill instructions: 4675 -> 4676 (+0.02%)
   Number of fill instructions: 5698 -> 5684 (-0.25%); split: -0.28%, +0.04%

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41215>
This commit is contained in:
Alyssa Rosenzweig 2026-04-20 17:33:16 -04:00 • committed by Marge Bot
parent 796886f72c
commit 2c77717e5c
1 changed files with 15 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
src/intel/compiler/jay/jay_assign_flags.c
View file

@ -47,6 +47,7 @@ static_assert(sizeof(struct var_info) == 1);
struct flag_ra {
jay_builder *b;
struct var_info *vars;
unsigned nr_vars;
uint32_t flag_to_global[JAY_MAX_FLAGS];
uint32_t flag_to_local[JAY_MAX_FLAGS];
unsigned roundrobin;
@ -70,13 +71,15 @@ assign_flag(struct flag_ra *ra,
unsigned num_flags = jay_num_regs(ra->b->shader, FLAG);
tmp.reg = tie ? tie->reg :
ballot ? 0 :
(1 + (ra->roundrobin++) % (num_flags - 2));
(1 + ((ra->roundrobin++) % (num_flags - 1)));
ra->vars[jay_index(canonical)] = (struct var_info) {
.uniform = tmp.file == UFLAG,
.flag = tmp.reg,
.free_canonical = free_canonical,
};
if (jay_index(canonical) < ra->nr_vars) {
ra->vars[jay_index(canonical)] = (struct var_info) {
.uniform = tmp.file == UFLAG,
.flag = tmp.reg,
.free_canonical = free_canonical,
};
}
ra->flag_to_global[tmp.reg] = jay_index(canonical);
ra->flag_to_local[tmp.reg] = jay_index(tmp);
@ -300,9 +303,11 @@ assign_block(struct flag_ra *ra, jay_block *block)
/* Recover the canonical representation with a CMP. Hopefully,
* either the CMP or the cmod will be eliminated by a later DCE.
*/
jay_CMP(b, I->type, I->conditional_mod, canonical, I->dst, 0)
->cond_flag.reg =
jay_num_regs(b->shader, FLAG) - 1; // TODO: no null flag
jay_inst *cmp =
jay_CMP(b, I->type, I->conditional_mod, canonical, I->dst, 0);
cmp->cond_flag =
assign_flag(ra, cmp->cond_flag, cmp->cond_flag.file,
true /* free_canonical */, false /* ballot */, NULL);
}
}
}
@ -370,7 +375,7 @@ jay_assign_flags(jay_shader *s)
jay_foreach_block(f, block) {
jay_builder b = { .shader = f->shader, .func = f };
struct flag_ra ra = { .b = &b, .vars = map };
struct flag_ra ra = { .b = &b, .vars = map, .nr_vars = nr_vars };
assign_block(&ra, block);
}