From 2c6e8b2dd5fc3e85c0691367155aba3c626eaf16 Mon Sep 17 00:00:00 2001 From: Eric Engestrom Date: Fri, 19 Jul 2024 16:08:57 +0200 Subject: [PATCH] =?UTF-8?q?Revert=20"bin/ci=5Frun=5Fn=5Fmonitor:=20explain?= =?UTF-8?q?=20that=20the=20'Universal=20Recycling=20symbol'=20=E2=99=B2=20?= =?UTF-8?q?emoji=20means=20these=20jobs=20were=20cancelled"?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 032d4a20f90006ce421a78ae30ff8c9f7469d27e. The `if not to_cancel: return` was a red herring as what actually matters is the job status, which is checked in each cancel_job() call, so we can't know in advance whether anything will be cancelled, so let's just drop this text explanation. In the meantime we've also improved the emoji next to cancelled jobs, so let's hope there is no longer any need to explain what this long list of job names means. Fixes: 032d4a20f90006ce421a ("bin/ci_run_n_monitor: explain that the 'Universal Recycling symbol' ♲ emoji means these jobs were cancelled") Part-of: --- bin/ci/ci_run_n_monitor.py | 1 - 1 file changed, 1 deletion(-) diff --git a/bin/ci/ci_run_n_monitor.py b/bin/ci/ci_run_n_monitor.py index 4e4a974d625..80340cb13cf 100755 --- a/bin/ci/ci_run_n_monitor.py +++ b/bin/ci/ci_run_n_monitor.py @@ -286,7 +286,6 @@ def cancel_jobs( if not to_cancel: return - print("Cancelled jobs: ", end=" ") with ThreadPoolExecutor(max_workers=6) as exe: part = partial(cancel_job, project) exe.map(part, to_cancel)