From 2bce101eb32bb3724d060e31742478486e908c89 Mon Sep 17 00:00:00 2001 From: Samuel Pitoiset Date: Thu, 28 Sep 2023 10:23:20 +0200 Subject: [PATCH] radv: enable DCC for MSAA images on GFX11 This seems to be working now! I suspect either the "recent" addrlib update fixed it or recent comp-to-single fast clear fixes. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8326 Signed-off-by: Samuel Pitoiset Part-of: --- src/amd/vulkan/radv_image.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c index 1fedc8d7406..484f8cd8647 100644 --- a/src/amd/vulkan/radv_image.c +++ b/src/amd/vulkan/radv_image.c @@ -273,8 +273,9 @@ radv_use_dcc_for_image_early(struct radv_device *device, struct radv_image *imag return false; } - /* FIXME: Figure out how to use DCC for MSAA images without FMASK. */ - if (pCreateInfo->samples > 1 && !device->physical_device->use_fmask) + /* DCC MSAA can't work on GFX10.3 and earlier without FMASK. */ + if (pCreateInfo->samples > 1 && device->physical_device->rad_info.gfx_level < GFX11 && + (device->instance->debug_flags & RADV_DEBUG_NO_FMASK)) return false; return radv_are_formats_dcc_compatible(device->physical_device, pCreateInfo->pNext, format, pCreateInfo->flags,