fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-06 20:18:12 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

pan/lib: divide extent by tile-extend, not itself

Browse source 
Dividing this by itself is nonsensical, and just always gives us one.
That's obviously not what we want here.

But in this case we also know that the extent is divisible by the tile
extent, so there's no need for DIV_ROUND_UP, we can just divide.

Fixes: e6f8cab698 ("pan/layout: Split the logic per modifier")
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com>
(cherry picked from commit 5280b80281)

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/40752>
This commit is contained in:
Erik Faye-Lund 2026-03-18 16:06:03 +01:00 • committed by Eric Engestrom
parent ad057adfd4
commit 2953656a39
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -5864,7 +5864,7 @@
"description": "pan/lib: divide extent by tile-extend, not itself",
"nominated": true,
"nomination_type": 2,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "e6f8cab69890e1b814bd58ec7cab06ba52aa7bb9",
"notes": null

2
src/panfrost/lib/pan_mod.c
View file

@ -407,7 +407,7 @@ pan_mod_afrc_init_slice_layout(
uint64_t surf_stride_B =
(uint64_t)slayout->tiled_or_linear.row_stride_B *
DIV_ROUND_UP(aligned_extent_px.height, aligned_extent_px.height);
(aligned_extent_px.height / tile_extent_px.height);
slayout->tiled_or_linear.surface_stride_B = surf_stride_B;
slayout->size_B =