fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-07 17:58:26 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

nir/opt_load_store_vectorize: Use bit sizes when checking mask compatibility

Browse source 
Without this, it was checking bit size compatibility with bit sizes such
as 96 which is clearly invalid.

No shader-db changes on Ice Lake

Fixes: ce9205c03b "nir: add a load/store vectorization pass"
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6871>
(cherry picked from commit 57e7c5f05e)
This commit is contained in:
Jason Ekstrand 2020-09-25 16:29:23 -05:00 • committed by Dylan Baker
parent 1784d889f2
commit 285d4d0787
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -598,7 +598,7 @@
"description": "nir/opt_load_store_vectorize: Use bit sizes when checking mask compatibility",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"master_sha": null,
"because_sha": "ce9205c03bd20d26af23ca891e97a9f848a612d1"
},

4
src/compiler/nir/nir_opt_load_store_vectorize.c
View file

@ -709,11 +709,11 @@ new_bitsize_acceptable(struct vectorize_ctx *ctx, unsigned new_bit_size,
return false;
unsigned write_mask = nir_intrinsic_write_mask(low->intrin);
if (!writemask_representable(write_mask, low_size, new_bit_size))
if (!writemask_representable(write_mask, get_bit_size(low), new_bit_size))
return false;
write_mask = nir_intrinsic_write_mask(high->intrin);
if (!writemask_representable(write_mask, high_size, new_bit_size))
if (!writemask_representable(write_mask, get_bit_size(high), new_bit_size))
return false;
}