fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 16:08:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

anv/video: Read the right source for memcpy

Browse source 
I'm assuming this based off the `if` branch above, after reading the
code for bit that Coverity pointed out in that branch. It doesn't look
correct to start at the base pointer, which will be 0 initialized and
has 52 bits of zero padding, while the default values are 255.

Fixes: 314de7af06 ("anv: Initial support for VP9 decoding")
Reviewed-by: Hyunjun Ko <zzoon@igalia.com>
(cherry picked from commit 0735551b08)

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/39003>
This commit is contained in:
Dylan Baker 2025-11-13 13:44:24 -08:00
parent de96d98ae3
commit 26d7753c99
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -374,7 +374,7 @@
"description": "anv/video: Read the right source for memcpy",
"nominated": true,
"nomination_type": 2,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "314de7af063ff7f40c10df8cd022f35e5eb7fa1a",
"notes": null

2
src/intel/vulkan/anv_video.c
View file

@ -1276,7 +1276,7 @@ vp9_prob_buf_update(struct anv_video_session *vid,
} else if (BITSET_TEST(vid->prob_tbl_set, 3)) {
VP9_CTX_DEFAULT(seg_tree_probs);
VP9_CTX_DEFAULT(seg_pred_probs);
memcpy(ptr + SEG_PROBS_OFFSET, &ctx,
memcpy(ptr + SEG_PROBS_OFFSET, (void *)&ctx.seg_tree_probs,
SEG_TREE_PROBS + PREDICTION_PROBS);
}