From 268a1db7ccfd6dfd424cc81a13a8b08798df98cd Mon Sep 17 00:00:00 2001 From: Faith Ekstrand Date: Mon, 27 Oct 2025 14:58:28 -0400 Subject: [PATCH] nvk: Advertise the new maintenance10 format features We don't actually advertise compute-only or depth-only queues right now but nothing in the spec says you have to advertise the queues in order to advertise the bits. Setting them now ensures we don't forget them when compute-only or transfer-only queues get added. Reviewed-by: Mel Henning Part-of: --- src/nouveau/vulkan/nvk_image.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/nouveau/vulkan/nvk_image.c b/src/nouveau/vulkan/nvk_image.c index a4905e9d493..d753c1312b1 100644 --- a/src/nouveau/vulkan/nvk_image.c +++ b/src/nouveau/vulkan/nvk_image.c @@ -109,6 +109,16 @@ nvk_get_image_plane_format_features(const struct nvk_physical_device *pdev, features |= VK_FORMAT_FEATURE_2_TRANSFER_DST_BIT; if (!vk_format_is_depth_or_stencil(vk_format)) features |= VK_FORMAT_FEATURE_2_HOST_IMAGE_TRANSFER_BIT_EXT; + + /* The copy engine handles depth and stencil just fine */ + if (vk_format_has_depth(vk_format)) { + features |= VK_FORMAT_FEATURE_2_DEPTH_COPY_ON_COMPUTE_QUEUE_BIT_KHR | + VK_FORMAT_FEATURE_2_DEPTH_COPY_ON_TRANSFER_QUEUE_BIT_KHR; + } + if (vk_format_has_stencil(vk_format)) { + features |= VK_FORMAT_FEATURE_2_STENCIL_COPY_ON_COMPUTE_QUEUE_BIT_KHR | + VK_FORMAT_FEATURE_2_STENCIL_COPY_ON_TRANSFER_QUEUE_BIT_KHR; + } } return features;