From 2527e18eebe2faf395d1682db7df76043aca6ea3 Mon Sep 17 00:00:00 2001 From: Martina Kollarova Date: Thu, 8 Sep 2016 15:12:42 +0300 Subject: [PATCH] gallium: fix return value check MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A possible error (-1) was being lost because it was first converted to an unsigned int and only then checked. Reviewed-by: Nicolai Hähnle Signed-off-by: Martina Kollarova Reviewed-by: Eric Engestrom --- .../winsys/sw/kms-dri/kms_dri_sw_winsys.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c b/src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c index 07eca990d04..22e1c936ac5 100644 --- a/src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c +++ b/src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c @@ -252,17 +252,17 @@ kms_sw_displaytarget_add_from_prime(struct kms_sw_winsys *kms_sw, int fd, if (!kms_sw_dt) return NULL; - kms_sw_dt->ref_count = 1; - kms_sw_dt->handle = handle; - kms_sw_dt->size = lseek(fd, 0, SEEK_END); - kms_sw_dt->width = width; - kms_sw_dt->height = height; - kms_sw_dt->stride = stride; - - if (kms_sw_dt->size == (off_t)-1) { + off_t lseek_ret = lseek(fd, 0, SEEK_END); + if (lseek_ret == -1) { FREE(kms_sw_dt); return NULL; } + kms_sw_dt->size = lseek_ret; + kms_sw_dt->ref_count = 1; + kms_sw_dt->handle = handle; + kms_sw_dt->width = width; + kms_sw_dt->height = height; + kms_sw_dt->stride = stride; lseek(fd, 0, SEEK_SET);