fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 20:28:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

zink: fix line-stipple varying allocation

Browse source 
This was really derpy. There's two things wrong; first of all, we should
pick at LEAST VARYING_SLOT_VAR0, second, util_last_bit64 returns one
more than the index of the bit already, so we don't want to add twice
here.

Fixes: 4b17c099ca ("zink: add line-stippling lowering passes")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19847>
This commit is contained in:
Erik Faye-Lund 2022-12-01 22:17:42 +01:00 • committed by Marge Bot
parent f135309e73
commit 23f1294f42
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/gallium/drivers/zink/zink_compiler.c
View file

@ -463,7 +463,7 @@ lower_line_stipple_gs(nir_shader *shader)
"__stipple");
state.stipple_out->data.interpolation = INTERP_MODE_NOPERSPECTIVE;
state.stipple_out->data.driver_location = shader->num_outputs++;
state.stipple_out->data.location = MIN2(util_last_bit64(shader->info.outputs_written) + 1, VARYING_SLOT_VAR0);
state.stipple_out->data.location = MAX2(util_last_bit64(shader->info.outputs_written), VARYING_SLOT_VAR0);
shader->info.outputs_written |= BITFIELD64_BIT(state.stipple_out->data.location);
// create temp variables
@ -501,7 +501,7 @@ lower_line_stipple_fs(nir_shader *shader)
"__stipple");
stipple->data.interpolation = INTERP_MODE_NOPERSPECTIVE;
stipple->data.driver_location = shader->num_inputs++;
stipple->data.location = MIN2(util_last_bit64(shader->info.inputs_read) + 1, VARYING_SLOT_VAR0);
stipple->data.location = MAX2(util_last_bit64(shader->info.inputs_read), VARYING_SLOT_VAR0);
shader->info.inputs_read |= BITFIELD64_BIT(stipple->data.location);
nir_variable *sample_mask_out =