From 23c0d64e240fa16d9bef62020abaa122d462759e Mon Sep 17 00:00:00 2001 From: Erico Nunes Date: Thu, 10 Apr 2025 16:32:29 +0200 Subject: [PATCH] panvk: disable VK_EXT_image_drm_format_modifier for arch < 10 VK_KHR_sampler_ycbcr_conversion is a dependency from the VK_EXT_image_drm_format_modifier spec. panvk arch < 10 still doesn't support it, so VK_EXT_image_drm_format_modifier should not be exposed. Otherwise, a Vulkan validation error is triggered for users of VK_EXT_image_drm_format_modifier and it may cause applications to fail to create a device. Signed-off-by: Erico Nunes Reviewed-by: Erik Faye-Lund Part-of: --- src/panfrost/vulkan/panvk_physical_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/panfrost/vulkan/panvk_physical_device.c b/src/panfrost/vulkan/panvk_physical_device.c index 5d063c66e3d..60b6c0b3a22 100644 --- a/src/panfrost/vulkan/panvk_physical_device.c +++ b/src/panfrost/vulkan/panvk_physical_device.c @@ -285,7 +285,8 @@ get_device_extensions(const struct panvk_physical_device *device, .EXT_graphics_pipeline_library = true, .EXT_hdr_metadata = true, .EXT_host_query_reset = true, - .EXT_image_drm_format_modifier = true, + /* EXT_image_drm_format_modifier depends on KHR_sampler_ycbcr_conversion */ + .EXT_image_drm_format_modifier = arch >= 10, .EXT_image_robustness = true, .EXT_index_type_uint8 = true, .EXT_line_rasterization = true,