fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-26 12:50:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

util/disk_cache: remove percentage based max cache limit

Browse source 
The more I think about it the more this seems like a bad idea.
When we were deleting old cache dirs this wasn't so bad as it
was unlikely we would ever hit the actual limit before things
were cleaned up. Now that we only start cleaning up old cache
items once the limit is reached the a percentage based max
cache limit is more risky.

For the inital release of shader cache I think its better to
stick to a more conservative cache limit, at least until we
have some way of cleaning up the cache more aggressively.

Cc: "17.1" <mesa-stable@lists.freedesktop.org>
Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
This commit is contained in:
Timothy Arceri 2017-04-28 13:05:52 +10:00
parent 032861693e
commit 22fa3d90a9
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/util/disk_cache.c
View file

@ -31,7 +31,6 @@
#include <sys/file.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <sys/statvfs.h>
#include <sys/mman.h>
#include <unistd.h>
#include <fcntl.h>
@ -47,7 +46,6 @@
#include "util/mesa-sha1.h"
#include "util/ralloc.h"
#include "main/errors.h"
#include "util/macros.h"
#include "disk_cache.h"
@ -171,7 +169,6 @@ disk_cache_create(const char *gpu_name, const char *timestamp)
uint64_t max_size;
int fd = -1;
struct stat sb;
struct statvfs vfs = { 0 };
size_t size;
/* If running as a users other than the real user disable cache */
@ -331,10 +328,9 @@ disk_cache_create(const char *gpu_name, const char *timestamp)
}
}
/* Default to 1GB or 5% of filesystem for maximum cache size. */
/* Default to 1GB for maximum cache size. */
if (max_size == 0) {
statvfs(path, &vfs);
max_size = MAX2(1024*1024*1024, vfs.f_blocks * vfs.f_bsize / 20);
max_size = 1024*1024*1024;
}
cache->max_size = max_size;