fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-23 13:20:14 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

nir/format_convert: Assert that UNORM formats are <= 16 bits

Browse source 
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28793>
This commit is contained in:
Faith Ekstrand 2024-06-18 10:52:51 -05:00 • committed by Marge Bot
parent 5f5f4474f6
commit 22f1b04a99
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/compiler/nir/nir_format_convert.c
View file

@ -199,7 +199,11 @@ _nir_format_norm_factor(nir_builder *b, const unsigned *bits,
nir_const_value factor[NIR_MAX_VEC_COMPONENTS];
memset(factor, 0, sizeof(factor));
for (unsigned i = 0; i < num_components; i++) {
assert(bits[i] <= 32);
/* A 16-bit float only has 23 bits of mantissa. This isn't enough to
* convert 24 or 32-bit UNORM/SNORM accurately. For that, we would need
* fp64 or some sort of fixed-point math.
*/
assert(bits[i] <= 16);
factor[i].f32 = (1ull << (bits[i] - is_signed)) - 1;
}
return nir_build_imm(b, num_components, 32, factor);