From 22759e91740e589989e019f92beaa3cd5ba299bb Mon Sep 17 00:00:00 2001 From: "Juan A. Suarez Romero" Date: Thu, 17 Mar 2022 11:24:49 +0100 Subject: [PATCH] v3dv: add subpixel precision definition Move number of bits for subpixel precision in rasterizer to a define. Signed-off-by: Juan A. Suarez Romero Reviewed-by: Iago Toral Quiroga Part-of: --- src/broadcom/common/v3d_limits.h | 3 +++ src/broadcom/vulkan/v3dv_device.c | 8 +++----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/broadcom/common/v3d_limits.h b/src/broadcom/common/v3d_limits.h index 129e53e29a4..465802c5123 100644 --- a/src/broadcom/common/v3d_limits.h +++ b/src/broadcom/common/v3d_limits.h @@ -64,4 +64,7 @@ #define V3D_MAX_BUFFER_RANGE (1 << 27) +/* Sub-pixel precission bits in the rasterizer */ +#define V3D_COORD_SHIFT 6 + #endif /* V3D_LIMITS_H */ diff --git a/src/broadcom/vulkan/v3dv_device.c b/src/broadcom/vulkan/v3dv_device.c index 751b97eacec..9cc45115932 100644 --- a/src/broadcom/vulkan/v3dv_device.c +++ b/src/broadcom/vulkan/v3dv_device.c @@ -1346,9 +1346,7 @@ v3dv_GetPhysicalDeviceProperties(VkPhysicalDevice physicalDevice, const uint32_t max_varying_components = 16 * 4; - const uint32_t v3d_coord_shift = 6; - - const float v3d_point_line_granularity = 2.0f / (1 << v3d_coord_shift); + const float v3d_point_line_granularity = 2.0f / (1 << V3D_COORD_SHIFT); const uint32_t max_fb_size = 4096; const VkSampleCountFlags supported_sample_counts = @@ -1434,7 +1432,7 @@ v3dv_GetPhysicalDeviceProperties(VkPhysicalDevice physicalDevice, .maxComputeWorkGroupInvocations = 256, .maxComputeWorkGroupSize = { 256, 256, 256 }, - .subPixelPrecisionBits = v3d_coord_shift, + .subPixelPrecisionBits = V3D_COORD_SHIFT, .subTexelPrecisionBits = 8, .mipmapPrecisionBits = 8, .maxDrawIndexedIndexValue = 0x00ffffff, @@ -1456,7 +1454,7 @@ v3dv_GetPhysicalDeviceProperties(VkPhysicalDevice physicalDevice, .maxTexelGatherOffset = 7, .minInterpolationOffset = -0.5, .maxInterpolationOffset = 0.5, - .subPixelInterpolationOffsetBits = v3d_coord_shift, + .subPixelInterpolationOffsetBits = V3D_COORD_SHIFT, .maxFramebufferWidth = max_fb_size, .maxFramebufferHeight = max_fb_size, .maxFramebufferLayers = 256,